unify requirements in a single place #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkopac
approved these changes
Apr 28, 2025
keith-chartmogul
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went down a bit of a rabbit hole on this one...
I started off looking at
urllib3and noticing that while the changelog says>=2.2.3I'm actually locked to2.2.2in my production environment. This is because the CI tests are run usingrequirements.txtbut anyone using this package uses the requirements insetup.py. Then I noticed there's more discrepancies... You have arequirements-test.txtbut it's not actually used at all for the CI, therequirements.txthas other discrepancies from what's quoted insetup.py,setup.pyis usingtest_requireandtest_suitebut neither actually exist any more insetuptools...I didn't want to spend too much time on this, so ended up with this change to limit how much I'm rewriting. This PR puts all the requirements in a single place in
setup.py. However, developments in python packaging mean these things should really be insetup.cfg(you'll get a warning about it if you run the README suggestedpython setup.py develop).